search

awslabs / aws-sdk-rust

AWS SDK for the Rust Programming Language
https://awslabs.github.io/aws-sdk-rust/
Apache License 2.0
2.98k stars 246 forks source link

SQS `ReceiveMessageFluentBuilder` `fn attribute_names` deprecation #1145

Closed Smotrov closed 4 months ago

Smotrov commented 4 months ago

Describe the issue

It is written now 

pub fn attribute_names(self, input: QueueAttributeName) -> Self
👎Deprecated: AttributeNames has been replaced by MessageSystemAttributeNames

But there is no AttributeNames in the function definition. Moreover the case is not something is replaced by MessageSystemAttributeNames but fn attribute_names is replaced.

So it looks a bit confusing.

Links

Documentation link

aajtodd commented 4 months ago

Thanks for the issue.

But there is no AttributeNames in the function definition.

This deprecation comes directly from the model and is referring to the modeled shapes AttributeNames and MessageSystemAttributeNames.

Moreover the case is not something is replaced by MessageSystemAttributeNames but fn attribute_names is replaced.

I'm not sure I follow your point here but the deprecation applies to the input member AttributeNames and so any fluent builder function generated to set or get that field is deprecated essentially (e.g. even get_attribute_names()).

Unfortunately there isn't much we can do here as deprecation text is open ended and so no way to easily link things if we wanted to. I'm going to go ahead and close this as there isn't anything actionable here.

github-actions[bot] commented 4 months ago

Comments on closed issues are hard for our team to see. If you need more assistance, please either tag a team member or open a new issue that references this one. If you wish to keep having a conversation with other community members under this issue feel free to do so.