search

awslabs / aws-sdk-swift

Apache License 2.0
383 stars 75 forks source link

Bug: Fix Boxing of Shapes on several services. #272

Closed kneekey23 closed 3 years ago

kneekey23 commented 3 years ago

Ignore unboxed types for subset of services. Some services don't properly respect the box trait in Smithy. In order to appropriately fix the issues caused by this, you need to pre-process the model to box all the primitive shapes like Rust has done here: https://github.com/awslabs/smithy-rs/blob/14f435e864e20dcfe401d39e456e363e12030b94/aws/sdk-codegen/src/main/kotlin/software/amazon/smithy/rustsdk/customize/ec2/Ec2Decorator.kt#L14 https://github.com/awslabs/smithy-rs/blob/14f435e864e20dcfe401d39e456e363e12030b94/aws/sdk-codegen/src/main/kotlin/software/amazon/smithy/rustsdk/customize/ec2/BoxPrimitiveShapes.kt#L27

Three services are:; ["EC2","AmazonNimbleStudio","AmplifyBackend","ApiGatewayManagementApi","ApiGatewayV2","DataExchange","Greengrass","IoT 1Click Projects","Kafka","Macie2","MediaConnect","MediaConvert","MediaLive","MediaPackage","MediaPackage Vod","MediaTailor","Pinpoint","Pinpoint SMS Voice","ServerlessApplicationRepository","mq","schemas"]

kneekey23 commented 3 years ago

There is some talk that this may eventually get up-streamed so that we don't have to handle it. Unsure of timeline at the moment. Punting this for now. Before picking up, check with Smithy team.