search

awslabs / aws-service-catalog-factory

This is a framework where you define a Service Catalog portfolio, products and versions using YAML. For versions of your products you specify where the source code for them can be found and the framework publishes the portfolio, products and versions in every* AWS Region after validating, linting and testing them.
Apache License 2.0
136 stars 44 forks source link

Change default for PollForSourceChanges with CodeCommit to False #336

Closed RobBrazier closed 1 year ago

RobBrazier commented 1 year ago

Issue #, if available: Fixes #335

Description of changes: Change default of PollForSourceChanges back to False to prevent hitting periodic source checks quota limit (which doesn't seem to be changeable)

I did notice that S3 defaults to True as well, however I didn't change that to try and reduce the potential impact

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

eamonnfaherty commented 1 year ago

Thanks for the contribution and sorry I missed this. If you do not get a response on a PR within 3 working days feel free to email me a nudge.