awslabs / aws-service-catalog-puppet

This is a framework where you list your AWS accounts with tags and your AWS Service Catalog products with tags or target accounts. The framework works through your lists, dedupes and spots collisions and then provisions the products into your AWS accounts for you. It handles the Portfolio sharing, its acceptance and can provision products cross account and cross region.

Apache License 2.0

75 stars 41 forks source link

ServiceCatalog Puppet fails due to PutEvents limit reached #537

Closed vc00778402 closed 2 years ago

vc00778402 commented 2 years ago

The pipeline failed due to the putevents limit exhausted. The data on manifest file is large to parse hence it failed.

Steps to reproduce

Just run the pipeline with the attached manifest file

Expected results

Should create IAM roles on accounts added on manifest file

Actual results

botocore.exceptions.ClientError: An error occurred (ValidationException) when calling the PutEvents operation: Total size of the entries in the request is over the limit. puppet-pipeline-logs.zip manifest.zip

eamonnfaherty commented 2 years ago

fixed in 0.184.0

vc00778402 commented 2 years ago

The issue still persists after upgrading to 0.184.0. Kindly assist.

eamonnfaherty commented 2 years ago

Can you share the cloud trail event for the error please.

The error should not be blocking anything. The error occurs after the workflow has completed and is a reporting action.

There is a workaround of turning off event bridge integration.

eamonnfaherty commented 2 years ago

can you share the cloudtrail event or your artefacts for the run where you saw the failure.

vc00778402 commented 2 years ago

Hi Eamonn,

I've attached the logs and the Artifacts. Meanwhile can you explain how do we go about "turning off event bridge integration" that you mentioned as a workaround?

[removed]

eamonnfaherty commented 2 years ago

it is a parameter in the initialiser stack. you should be able to turn it off easily.

from your artifacts I can see the launch_parameters and manifest_parameters for your launch xxx-core-managed-vpc-db-connected are significantly larger (27x) than expected. This is valid but sort of an edge case. I will need to make an update to get this working. I should be able to drop a release by Thursday.

I do not think I will need a CloudTrail event as I have this but if you manage to find it please share it.

Murali5189 commented 2 years ago

@eamonnfaherty Is there any update on this issue ?

eamonnfaherty commented 2 years ago

this is now fixed