search

awslabs / aws-service-catalog-puppet

This is a framework where you list your AWS accounts with tags and your AWS Service Catalog products with tags or target accounts. The framework works through your lists, dedupes and spots collisions and then provisions the products into your AWS accounts for you. It handles the Portfolio sharing, its acceptance and can provision products cross account and cross region.
Apache License 2.0
76 stars 41 forks source link

Fix/optimising task reference #670

Closed eamonnfaherty closed 1 year ago

eamonnfaherty commented 1 year ago

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 40.09% and project coverage change: -0.06 :warning:

Comparison is base (85f7a83) 41.95% compared to head (66eff52) 41.90%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #670 +/- ## ========================================== - Coverage 41.95% 41.90% -0.06% ========================================== Files 186 187 +1 Lines 9708 9766 +58 Branches 1296 1306 +10 ========================================== + Hits 4073 4092 +19 - Misses 5551 5590 +39 Partials 84 84 ``` | [Impacted Files](https://app.codecov.io/gh/awslabs/aws-service-catalog-puppet/pull/670?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs) | Coverage Δ | | |---|---|---| | [servicecatalog\_puppet/commands/task\_reference.py](https://app.codecov.io/gh/awslabs/aws-service-catalog-puppet/pull/670?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs#diff-c2VydmljZWNhdGFsb2dfcHVwcGV0L2NvbW1hbmRzL3Rhc2tfcmVmZXJlbmNlLnB5) | `0.00% <ø> (ø)` | | | [...mands/task\_reference\_helpers/complete\_generator.py](https://app.codecov.io/gh/awslabs/aws-service-catalog-puppet/pull/670?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs#diff-c2VydmljZWNhdGFsb2dfcHVwcGV0L2NvbW1hbmRzL3Rhc2tfcmVmZXJlbmNlX2hlbHBlcnMvY29tcGxldGVfZ2VuZXJhdG9yLnB5) | `0.00% <0.00%> (ø)` | | | [...sk\_reference\_helpers/generators/c7n\_aws\_lambdas.py](https://app.codecov.io/gh/awslabs/aws-service-catalog-puppet/pull/670?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs#diff-c2VydmljZWNhdGFsb2dfcHVwcGV0L2NvbW1hbmRzL3Rhc2tfcmVmZXJlbmNlX2hlbHBlcnMvZ2VuZXJhdG9ycy9jN25fYXdzX2xhbWJkYXMucHk=) | `0.00% <0.00%> (ø)` | | | [...ands/task\_reference\_helpers/generators/launches.py](https://app.codecov.io/gh/awslabs/aws-service-catalog-puppet/pull/670?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs#diff-c2VydmljZWNhdGFsb2dfcHVwcGV0L2NvbW1hbmRzL3Rhc2tfcmVmZXJlbmNlX2hlbHBlcnMvZ2VuZXJhdG9ycy9sYXVuY2hlcy5weQ==) | `0.00% <0.00%> (ø)` | | | [...nce\_helpers/generators/service\_control\_policies.py](https://app.codecov.io/gh/awslabs/aws-service-catalog-puppet/pull/670?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs#diff-c2VydmljZWNhdGFsb2dfcHVwcGV0L2NvbW1hbmRzL3Rhc2tfcmVmZXJlbmNlX2hlbHBlcnMvZ2VuZXJhdG9ycy9zZXJ2aWNlX2NvbnRyb2xfcG9saWNpZXMucHk=) | `0.00% <0.00%> (ø)` | | | [...eference\_helpers/generators/ssm\_outputs\_handler.py](https://app.codecov.io/gh/awslabs/aws-service-catalog-puppet/pull/670?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs#diff-c2VydmljZWNhdGFsb2dfcHVwcGV0L2NvbW1hbmRzL3Rhc2tfcmVmZXJlbmNlX2hlbHBlcnMvZ2VuZXJhdG9ycy9zc21fb3V0cHV0c19oYW5kbGVyLnB5) | `0.00% <0.00%> (ø)` | | | [...mmands/task\_reference\_helpers/generators/stacks.py](https://app.codecov.io/gh/awslabs/aws-service-catalog-puppet/pull/670?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs#diff-c2VydmljZWNhdGFsb2dfcHVwcGV0L2NvbW1hbmRzL3Rhc2tfcmVmZXJlbmNlX2hlbHBlcnMvZ2VuZXJhdG9ycy9zdGFja3MucHk=) | `0.00% <0.00%> (ø)` | | | [.../task\_reference\_helpers/generators/tag\_policies.py](https://app.codecov.io/gh/awslabs/aws-service-catalog-puppet/pull/670?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs#diff-c2VydmljZWNhdGFsb2dfcHVwcGV0L2NvbW1hbmRzL3Rhc2tfcmVmZXJlbmNlX2hlbHBlcnMvZ2VuZXJhdG9ycy90YWdfcG9saWNpZXMucHk=) | `0.00% <0.00%> (ø)` | | | [...ds/task\_reference\_helpers/generators/workspaces.py](https://app.codecov.io/gh/awslabs/aws-service-catalog-puppet/pull/670?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs#diff-c2VydmljZWNhdGFsb2dfcHVwcGV0L2NvbW1hbmRzL3Rhc2tfcmVmZXJlbmNlX2hlbHBlcnMvZ2VuZXJhdG9ycy93b3Jrc3BhY2VzLnB5) | `0.00% <0.00%> (ø)` | | | [...puppet/workflow/launch/run\_deploy\_in\_spoke\_task.py](https://app.codecov.io/gh/awslabs/aws-service-catalog-puppet/pull/670?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs#diff-c2VydmljZWNhdGFsb2dfcHVwcGV0L3dvcmtmbG93L2xhdW5jaC9ydW5fZGVwbG95X2luX3Nwb2tlX3Rhc2sucHk=) | `33.33% <11.76%> (-25.50%)` | :arrow_down: | | ... and [11 more](https://app.codecov.io/gh/awslabs/aws-service-catalog-puppet/pull/670?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs) | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.