search

awslabs / aws-servicebroker

AWS Service Broker
Apache License 2.0
468 stars 131 forks source link

chart fails to find secret if --name not aws-servicebroker #123

Open jasonkuhrt opened 5 years ago

jasonkuhrt commented 5 years ago

I deployed:

helm install aws-sb/aws-servicebroker \
    --wait \
    --name catalog-aws \
    --namespace catalog-aws \
    --version 1.0.1 \
    --set aws.region=ca-central-1 \
    --set aws.s3region=ca-central-1 \
    --set aws.accesskeyid=***\
    --set aws.secretkey=***

But the pod is looking for a secret that is wrongly named:

❯ k get secret
NAME                                                TYPE                                  DATA   AGE
catalog-aws-aws-servicebroker                       kubernetes.io/service-account-token   3      14m
catalog-aws-aws-servicebroker-cert                  Opaque                                2      14m
catalog-aws-aws-servicebroker-client-token-m2c86    kubernetes.io/service-account-token   3      14m
catalog-aws-aws-servicebroker-credentials           Opaque                                2      14m
catalog-aws-aws-servicebroker-service-token-hvwgv   kubernetes.io/service-account-token   3      14m
default-token-wvn5h                                 kubernetes.io/service-account-token   3      15m

~
❯ k get events
LAST SEEN   TYPE      REASON              KIND         MESSAGE
16m         Normal    Scheduled           Pod          Successfully assigned catalog-aws/aws-servicebroker-aws-servicebroker-5897bc86c4-xs44n to ip-10-2-49-159.ec2.internal
15m         Normal    Pulling             Pod          pulling image "awsservicebroker/aws-servicebroker:beta"
15m         Normal    Pulled              Pod          Successfully pulled image "awsservicebroker/aws-servicebroker:beta"
15m         Normal    Created             Pod          Created container
15m         Normal    Started             Pod          Started container
15m         Warning   Failed              Pod          Error: secrets "aws-servicebroker-aws-servicebroker-credentials" not found

15m Warning Failed Pod Error: secrets "aws-servicebroker-aws-servicebroker-credentials" not found

jasonkuhrt commented 5 years ago

I ran with --dry-run --debug and was unable to see anywhere a badly named aws-servicebroker-aws-servicebroker-credentials. Which surprised me because I would have thought the error must come from the resources being sent... could be via a dynamic secret reference?

jasonkuhrt commented 5 years ago

But, confirmed, keeping --name as aws-servicebroker works around this issue.