search

awslabs / aws-shell

An integrated shell for working with the AWS CLI.
Apache License 2.0
7.18k stars 772 forks source link

Build autocomplete index in the background #1

Closed jamesls closed 8 years ago

jamesls commented 8 years ago

Especially with the addition of documentation, the index build can take a really long time. It would be better to build this in the background.

jamesls commented 8 years ago

Taking a look at this now. This is probably the most noticeable problem on a first-run.

jamesls commented 8 years ago

Update: I have a PR out to run the doc index in the background. #23 also makes the doc indexer incremental which was pretty straightforward.

Writing an incremental indexer for the autocompletion is more complicated. It also takes much less time than the doc indexer.

So what I'm thinking is rather than having an incremental/background indexer, I instead look at making the indexer as fast as I possibly can. There's certainly room for improvement.

jamesls commented 8 years ago

Closing out issue. The doc indexer runs in the background, which was the main issue. I think there's room to parallelize the initial autocomplete index, but I don't think this is necessary right now.