search

awslabs / aws-shell

An integrated shell for working with the AWS CLI.
Apache License 2.0
7.19k stars 775 forks source link

Upgrade to prompt_toolkit 0.57. #109

Closed jonathanslenders closed 8 years ago

jonathanslenders commented 8 years ago

Upgrade from prompt_toolkit 0.52 to 0.57.

The changelog: https://github.com/jonathanslenders/python-prompt-toolkit/blob/master/CHANGELOG If I have time, I can create also create a pull request for saws.

Feel free to not merge it if you have some doubts. I did some testing and it seems to work fine.

Jonathan

jamesls commented 8 years ago

Awesome thanks! I'll take a look at this shortly. IIRC the last time we looked at upgrading 0.52 -> 0.54 @donnemartin saw some cosmetic issues (https://github.com/awslabs/aws-shell/pull/78#issuecomment-165980787). Let me just double check those are no longer an issue.

donnemartin commented 8 years ago

Thanks Jonathan!

Yes James, I did see some issues with refresh, hopefully 0.57 fixes those. Looks like you're already checking this out, I'll probably free up later this week if you'd like for me to take a look.

donnemartin commented 8 years ago

Unfortunately I'm still seeing the issues described here.

I've tried several calls to cli redraws, cli reset, buffer reset, renderer reset, with no luck.

@jonathanslenders is there a call you can point me to properly force a refresh? The following doesn't seem to do the trick in app.py:

def stop_input_and_refresh_cli(self):
    ...
    self.cli.request_redraw()
    ...
jamesls commented 8 years ago

Closing in favor of the 1.0.0 upgrade. (https://github.com/awslabs/aws-shell/pull/120)