awslabs / aws-shell

An integrated shell for working with the AWS CLI.
Apache License 2.0
7.22k stars 779 forks source link

Use specific commit for pytest and bump pytest-cov #148

Closed joguSD closed 8 years ago

joguSD commented 8 years ago

Some changes to the cli exposed a bug in the stdin/out capturing feature of pytest. I've opened an upstream pull request to fix this and it has been merged: https://github.com/pytest-dev/pytest/pull/1866. Until this version releases next week, I'll be setting the pytest version to be a specific commit including the bugfix to get tests passing again.

@jamesls @kyleknap

JordonPhillips commented 8 years ago
--    .-""-.
   ) (     )
  (   )   (
     /     )
    (_    _)                     0_,-.__
      (_  )_                     |_.-._/
       (    )                    |_--..\
        (__)                     |__--_/
     |''   ``\                   |
     |        \                  |      /b.
     |         \  ,,,---===?A`\  |  ,==y'
   ___,,,,,---==""\        |M] \ | ;|\ |>
           _   _   \   ___,|H,,---==""""bno,
    o  O  (_) (_)   \ /          _     AWAW/
                     /         _(+)_  dMM/
      \@_,,,,,,---=="   \      \\|//  MW/
--''''"                         ===  d/
                                    //
                                    ,'__________________________
   \    \    \     \               ,/~~~~~~~~~~~~~~~~~~~~~~~~~~~
                         _____    ,'  ~~~   .-""-.~~~~~~  .-""-.
      .-""-.           ///==---   /`-._ ..-'      -.__..-'
            `-.__..-' =====\\\\\\ V/  .---\.
                      ~~~~~~~~~~~~, _',--/_.\  .-""-.
                            .-""-.___` --  \|         -.__..-
kyleknap commented 8 years ago

:ship: Might be good to put a todo comment on why you comment out 3.0.1 so that we remember, but if it gets quickly updated this should not be an issue.

joguSD commented 8 years ago

I was actually just about to update that comment to the correct version that the fix should be in.

kyleknap commented 8 years ago

Awesome. :ship: