awslabs / aws-shell

An integrated shell for working with the AWS CLI.
Apache License 2.0
7.15k stars 770 forks source link

Don't append 'aws' twice when invoking the .edit command #158

Closed joguSD closed 6 years ago

joguSD commented 7 years ago

The application.history already has 'aws' prepended so it is not needed in the list comprehension.

Fixes issue #157

donnemartin commented 7 years ago

Hi @joguSD, thanks for the PR! I'll try to review it this week.

donnemartin commented 7 years ago

Looks good to me, changes fix the problem on my end. @jamesls are you interested in taking a look?

@joguSD I wonder if we can start a unit test for the edit handler, starting with validating this change?

donnemartin commented 7 years ago

@jamesls would you like to do a review?

I wonder if we can start a unit test for the edit handler

I think this can probably go in a future TODO item, I can file a ticket.

joguSD commented 6 years ago

@jamesls Added the tests.