search

awslabs / aws-shell

An integrated shell for working with the AWS CLI.
Apache License 2.0
7.15k stars 770 forks source link

Add ci scripts #180

Closed joguSD closed 6 years ago

joguSD commented 6 years ago

Add some scripts to be used in CI

joguSD commented 6 years ago

@kyleknap Yeah I was planning on switching travis over after this. I was uncertain of what all should be checked in the jenkins builds vs travis builds. I agree it would be best if they're identical. Currently the shell checks more things than just the tests when run on travis. It runs a few linters to check the code quality. Do you think it would be best to add these additional checks to the run-tests script as well? If so, after the unit tests run we can add these code quality checks but I'm not sure what the fail behavior should be. Run all of these checks and then fail at the end?

JordonPhillips commented 6 years ago

@joguSD The way we do it in Chalice for instance is to have the validation be run as a distinct travis 'builds' (see here).

joguSD commented 6 years ago

@JordonPhillips That's how the shell is now more or less. Travis will only run these validations on Python 2.7.