search

awslabs / aws-shell

An integrated shell for working with the AWS CLI.
Apache License 2.0
7.17k stars 772 forks source link

Extract indexing out to separate package #21

Closed jamesls closed 8 years ago

jamesls commented 8 years ago

As part of extracting this out, I've also switch over to a plain JSON file for indexing the autocompletions. Much simpler and loads much faster.

I'm also starting to flesh out more of the tests. The FSLayer approach is borrowed from boto3, which has worked out well when testing the various S3 transfer functionality in boto3.

Closes #2.

jamesls commented 8 years ago

Oh, worth noting that I rebased off of https://github.com/awslabs/aws-shell/pull/20, so you'll unfortunately see that diff in this PR. If you have this checked out locally, I'd suggest git diff py3-startup..convert-json.

jamesls commented 8 years ago

@donnemartin Any interest in looking at this? It's just an internal refactoring but I wanted to check with your first.

donnemartin commented 8 years ago

@jamesls sorry I'm a little behind the code reviews. I'm interested in looking at them, even if it's just to better learn the codebase.

But please don't let me slow you down :)

Perhaps if I don't get to respond within a day, just :shipit: ?

kyleknap commented 8 years ago

Looks fine. :ship: I have not looked to closely into the architecture yet, but just had some small comments on stuff that looked a little fishy.

jamesls commented 8 years ago

Cool, I'll make the changes and merge. Some of this stuff is no longer applicable with the upcoming sqlite changes. Thanks for looking.