Closed donnemartin closed 8 years ago
Ah good catch, I'll update this.
Thanks for the fix James. I can hook up a pexpect
unit test to catch related errors. Here's an example of what I'm thinking:
https://github.com/donnemartin/saws/blob/master/tests/test_cli.py
Note pexpect
doesn't run on Windows, but that's probably fine since we're probably going to be running on Travis. If we use something like AppVeyor we'd need to hook up something like WExpect
.
I'd ideally like to find an approach that works on both linux/windows without much trouble. I don't remember if it was WExpect that I've used before, but I do remember running problems getting any kind of expect-like python library working on windows.
I think the issue right now is I can't hook this up to travis CI until this goes public so I don't have the usual travis CI checks I'm use to. I'm hoping this problem goes away shortly.
@jamesls I don't see the loaders module included in f709ba0d5d0081a5b3e67f57d27ab134d6a8d3e7, seems to be causing this issue: