search

awslabs / aws-shell

An integrated shell for working with the AWS CLI.
Apache License 2.0
7.17k stars 772 forks source link

Add cross platform temporary file creation #56

Closed jamesls closed 8 years ago

jamesls commented 8 years ago

Fixes #55

tempfile.NamedTemporaryFile creates a file that cannot be opened twice on windows. We had to make a similar change in the aws-cli a while back.

donnemartin commented 8 years ago

James, I had a couple questions/comments as line notes.

tempfile.NamedTemporaryFile creates a file that cannot be opened twice on windows.

I haven't had to work with tricky cross platform issues with tempfiles so my questions might reflect that :)

jamesls commented 8 years ago

Feedback incorporated. Ready for another look.

jamesls commented 8 years ago

Just got travis ci up and running, looks like there are few build failures from test_keys.py and test_config.py https://travis-ci.org/awslabs/aws-shell/jobs/97354667

I'll try to get those fixed in a separate PR and rerun travis CI on this PR once I get those passing.

donnemartin commented 8 years ago

Hmm, it seems like the template awsshellrc isn't getting copied to .tox. I can reproduce this locally if I delete the ~/.aws/shell directory then run tox.

 tree .tox | grep awsshellrc  # no results

I'm a bit tied up at the moment I'll see if I can free up later tonight.

[Edit] this quick investigation diagnosis was not correct, see followup comments.

donnemartin commented 8 years ago

Looking into this...

donnemartin commented 8 years ago

This should be fixed with https://github.com/awslabs/aws-shell/pull/62. w00t CI!

donnemartin commented 8 years ago

Feedback incorporated. Ready for another look.

Eeeeeexcellent, thanks! :shipit:

jamesls commented 8 years ago

Rebase against master, travis run now passing. Merging.