search

awslabs / aws-shell

An integrated shell for working with the AWS CLI.
Apache License 2.0
7.19k stars 775 forks source link

[Windows] not work in python ver 2.x.x #75

Open zeliard opened 8 years ago

zeliard commented 8 years ago

because of python-prompt-toolkit : https://github.com/jonathanslenders/python-prompt-toolkit/issues/86

But, It works well when using Python over 3.4.x.

You'd better change Readme.rst (https://github.com/awslabs/aws-shell#supported-python-versions).

jamesls commented 8 years ago

Thanks for the catch, I'll get the README updated.

donnemartin commented 8 years ago

Do you guys see a problem with aws-shell on your system with Python 2.x? The ticket referenced https://github.com/jonathanslenders/python-prompt-toolkit/issues/86 seems to indicate it's not easy to reproduce.

For aws-shell I've done a fair amount of testing on Win 10 64 bit with Python 2.7.6 32 bit and don't see any problems.

SAWS is also built on prompt_toolkit and I haven't seen any related issues logged against it. On Windows 7 64 bit and Windows 10 64 bit I haven't seen any problems either after much testing.

jamesls commented 8 years ago

When I first tried this last week, I got the traceback from https://github.com/jonathanslenders/python-prompt-toolkit/issues/86.

Today, I just tried it again and it worked (I guess that's the hard to repro part). Windows 2012 64 bit EC2 instance using powershell. I used the latest python 2.7.11 and it worked for me.

I think I can improve the installation instructions for windows users but I think I'll close https://github.com/awslabs/aws-shell/pull/77

donnemartin commented 8 years ago

Sounds good :+1: