search

awslabs / aws-shell

An integrated shell for working with the AWS CLI.
Apache License 2.0
7.15k stars 770 forks source link

Ensure clean "make check" output #90

Closed jamesls closed 8 years ago

jamesls commented 8 years ago

Before fixing issues or adding feature requests, let's set up make check to run cleanly. I've made a few changes:

  1. Change the pylint run to just use pylint -E. Even with a custom pylintrc there's too many false positives. I'm also not a fan of cluttering code with pylint exclusion comments.
  2. Add a make pylint that we can occasionally run and manually sift through any issues.
  3. Add make check as part of the travis builds.
  4. Small code cleanup to get make check to run cleanly.

The upcoming pull requests will use this as a base branch.

donnemartin commented 8 years ago

James, I'll try to review the pull requests early tomorrow morning.

donnemartin commented 8 years ago

Looks good :shipit: