search

awslabs / aws-shell

An integrated shell for working with the AWS CLI.
Apache License 2.0
7.15k stars 770 forks source link

Fail gracefully when no region is configured #91

Closed jamesls closed 8 years ago

jamesls commented 8 years ago

If we can't create a client for server side completion, we should not propogate an exception. Instead we should return no server side completion values.

In the future, it would be nice to have some sort of notification area in the shell where we could let the user know that server side completion won't work because they don't have a region configured.

As part of this work, I added an additional commit that refactors the server side completer to depend on the interfaces it needed. As a result, we don't need to use a boto3 Session directly.

Fixes #84.

donnemartin commented 8 years ago

Looks good, just a question about a comment block. :shipit:

jamesls commented 8 years ago

Merged via 060192f