search

awslabs / aws-solutions-constructs

The AWS Solutions Constructs Library is an open-source extension of the AWS Cloud Development Kit (AWS CDK) that provides multi-service, well-architected patterns for quickly defining solutions
https://docs.aws.amazon.com/solutions/latest/constructs/
Apache License 2.0
1.23k stars 246 forks source link

fix(step-functions):no longer attempt to modify cloudwatch logs permissions for state machines #1090

Closed biffgaut closed 7 months ago

biffgaut commented 7 months ago

Issue #, if available: Fixes #1089

Description of changes: We originally attempted to reduce the default permissions assigned by the CDK to a State Machine by limiting the resource by region and account for 3 Cloudwatch actions. Trying to do this via the escape hatch is problematic.

Looking deeper at the changes we were making, Cloudwatch Logs are regional so processes can't write log groups in different regions and accounts anyway - so our IAM modifications provided no tangible benefit. Since they were providing no benefit and were breaking client code, we've just removed them.

This approach is supported by Step Functions documentation - https://docs.aws.amazon.com/step-functions/latest/dg/cw-logs.html#cloudwatch-iam-policy

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

aws-solutions-constructs-team commented 7 months ago

AWS CodeBuild CI Report

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository