fix(aws-cloudfront-s3): disable cloudfront access logs when `logS3AccessLogs` is set to `false`

awslabs / aws-solutions-constructs

The AWS Solutions Constructs Library is an open-source extension of the AWS Cloud Development Kit (AWS CDK) that provides multi-service, well-architected patterns for quickly defining solutions

https://docs.aws.amazon.com/solutions/latest/constructs/

Apache License 2.0

1.19k stars 240 forks source link

fix(aws-cloudfront-s3): disable cloudfront access logs when `logS3AccessLogs` is set to `false` #1109

Closed garysassano closed 2 months ago

garysassano commented 2 months ago

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

aws-solutions-constructs-team commented 2 months ago

AWS CodeBuild CI Report

CodeBuild project: githubautobuild-for-cdk-v2
Commit ID: 9ad56c9424ba59ceb0c3fc0df44b2099799a17f1
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

biffgaut commented 2 months ago

Cloudfront access logs are controlled by cloudfront.DistributionProps.enableLogging, but since you have closed this PR I'm assuming that you came to this conclusion. If you have any additional questions, please don't hesitate to ask (although you will need to reopen this PR or start a new issue so we get a notification. Thanks for using Solutions Constructs!