search

awslabs / aws-solutions-constructs

The AWS Solutions Constructs Library is an open-source extension of the AWS Cloud Development Kit (AWS CDK) that provides multi-service, well-architected patterns for quickly defining solutions
https://docs.aws.amazon.com/solutions/latest/constructs/
Apache License 2.0
1.24k stars 247 forks source link

Ability for user to enable the AWS WAF web ACL #26

Closed hnishar closed 1 year ago

hnishar commented 4 years ago

Provide the user an option to enable the AWS WAF web ACL on the following patterns:

Use Case

AWS WAF provides an additional layer of protection to your web application. This feature will make it easy for user to enable AWS WAF web ACL for apigateway and cloudfront based patterns. These patterns will have an optional input parameter for user to provide the WAF web ACL that will be associated with the pattern created apigateway or cloudfront end point.

Proposed Solution

Add new optional input parameter (construct props) to accept the user provided WAF Web ACL for the following patterns:

Other

This is a :rocket: Feature Request

Jacco commented 2 years ago

While browsing for something to work on I found this issue. I doubt if this needs to be implemented because constructing this can be easily accomplished creating:

aws-wafwebacl-apigateway aws-wafwebacl-cloudfront

and then combining with the

aws-apigateway-lambda aws-apigateway-dynamodb aws-apigateway-sqs aws-cloudfront-apigateway aws-cloudfront-apigateway-lambda aws-cloudfront-s3 aws-cognito-apigateway-lambda

Is my assumption correct?

biffgaut commented 1 year ago

Sorry - missed your comment last year. Yes, the aws-wafwebacl-* constructs provide the functionality requested in this issue. We should have closed this issue when we released those, but will do so now.