awslabs / aws-support-tools

Tools and sample code provided by AWS Premium Support.
https://aws.amazon.com/premiumsupport/
Apache License 2.0
1.45k stars 798 forks source link

MWAA - Check Service Vpc Endpoints showing wrong results #165

Open cbroggi opened 3 years ago

cbroggi commented 3 years ago

Function _check_service_vpcendpoints returns wrong information, mentioning that not all vpc endpoints are associated with the corresponding subnets used in the environment creation of mwaa.

Context:

Promt image

What is expected:

image

Possible bug:

I think this line can be the problem: https://github.com/awslabs/aws-support-tools/blob/a143ec93ab2a68b230bc9781c19f7b681c7cd46f/MWAA/verify_env/verify_env.py#L658

it's checking whether all the subnets associated with the endpoints are present in the subnets of the MWAA environment, but it should be the other way around.

abigan09 commented 3 years ago

Hi, thanks for reaching out and pointing out this issue. I'm looking into this issue. I will get back here once I have more information.