awslabs / aws-support-tools

Tools and sample code provided by AWS Premium Support.
https://aws.amazon.com/premiumsupport/
Apache License 2.0
1.45k stars 798 forks source link

MWAA verify_env script incorrectly fails on checking public access block #205

Open daniel-bowman-nationwide opened 2 years ago

daniel-bowman-nationwide commented 2 years ago

https://github.com/awslabs/aws-support-tools/blob/2a9b97097a0851b674905e475958904ad6204d34/MWAA/verify_env/verify_env.py#L755

It should be fine to error on either bucket level or account level block. This raise causes script to break if permissions prevent checking public access block but permissions are available for account level block. Changing to return None worked as a temporary fix.