search

awslabs / aws-support-tools

Tools and sample code provided by AWS Premium Support.
https://aws.amazon.com/premiumsupport/
Apache License 2.0
1.44k stars 796 forks source link

MWAA verify TOP_LEVEL_DOMAIN is None #220

Open nagulvali555 opened 1 year ago

nagulvali555 commented 1 year ago

MWAA verify script fails with below error

top_level_domain = TOP_LEVEL_DOMAIN.split(".").reverse().join(".")

AttributeError: 'NoneType' object has no attribute 'join'

the above join statement seems to be wrong

devstek commented 1 year ago

Same here:

### Trying to verify if route tables are valid...
Route Table: rtb-123456789 does not have a route to a NAT Gateway
checking for VPC endpoints to airflow, s3, sqs, kms, ecr, and monitoring
Traceback (most recent call last):
  File "/home/t1-712980/git/aws-support-tools/MWAA/verify_env/verify_env.py", line 989, in <module>
    check_routes(env, subnets, subnet_ids, ec2)
  File "/home/t1-712980/git/aws-support-tools/MWAA/verify_env/verify_env.py", line 742, in check_routes
    check_service_vpc_endpoints(ec2_client, input_subnets)
  File "/home/t1-712980/git/aws-support-tools/MWAA/verify_env/verify_env.py", line 658, in check_service_vpc_endpoints
    top_level_domain = TOP_LEVEL_DOMAIN.split(".").reverse().join(".")
                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'NoneType' object has no attribute 'join'
yingchenjun commented 1 year ago

Got the same error here. do we know the cause here?

### Trying to verify if route tables are valid...
Route Table: rtb-xxxxxxxxxx does not have a route to a NAT Gateway
checking for VPC endpoints to airflow, s3, sqs, kms, ecr, and monitoring
Traceback (most recent call last):
  File "aws-support-tools/MWAA/verify_env/verify_env.py", line 989, in <module>
    check_routes(env, subnets, subnet_ids, ec2)
  File "aws-support-tools/MWAA/verify_env/verify_env.py", line 742, in check_routes
    check_service_vpc_endpoints(ec2_client, input_subnets)
  File "aws-support-tools/MWAA/verify_env/verify_env.py", line 658, in check_service_vpc_endpoints
    top_level_domain = TOP_LEVEL_DOMAIN.split(".").reverse().join(".")
AttributeError: 'NoneType' object has no attribute 'join'