search

awslabs / awsprocesscreds

Process credential providers for AWS SDKs and Tools
Apache License 2.0
132 stars 40 forks source link

remove implicit dependency on ~/.aws/credentials #20

Closed git-phu closed 6 years ago

git-phu commented 6 years ago

Issue #16

with this change awsprocesscreds no longer needs a default profile with access keys present in ~/.aws/credentials in order to run

this allows your default profile to use awsprocesscreds instead of access keys

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

codecov-io commented 6 years ago

Codecov Report

Merging #20 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #20   +/-   ##
=======================================
  Coverage   98.09%   98.09%           
=======================================
  Files           5        5           
  Lines         315      315           
  Branches       42       42           
=======================================
  Hits          309      309           
  Misses          3        3           
  Partials        3        3
Impacted Files Coverage Δ
awsprocesscreds/saml.py 100% <ø> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update af46070...1b3c624. Read the comment docs.

JordonPhillips commented 6 years ago

Thanks for the PR! This helped me to realize what was going on. While this would work, I think the proper solution is to fix the root issue in botocore itself. I created an issue in the botocore repo to track that: boto/botocore#1472

git-phu commented 6 years ago

awesome, sounds good!