asaranglr commented 6 years ago

Issue MFA seems to stall when using Okta and Google Authenticator app

Description of changes:

Get rid of saml assertion functionality from mfa_push
Update ambiguous user prompts

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

codecov-io commented 6 years ago

Codecov Report

Merging #21 into master will decrease coverage by 24.67%. The diff coverage is 31.76%.

@@             Coverage Diff             @@
##           master      #21       +/-   ##
===========================================
- Coverage   98.09%   73.42%   -24.68%     
===========================================
  Files           5        5               
  Lines         315      459      +144     
  Branches       42       75       +33     
===========================================
+ Hits          309      337       +28     
- Misses          3      117      +114     
- Partials        3        5        +2

Impacted Files	Coverage Δ
awsprocesscreds/cli.py	`96.15% <100%> (ø)`	:arrow_up:
awsprocesscreds/saml.py	`68.21% <30.95%> (-31.79%)`	:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update af46070...d309085. Read the comment docs.

JordonPhillips commented 6 years ago

It looks like you pulled in a bunch of other prs, could you please limit this to the title feature?

asaranglr commented 5 years ago

Apologies for the delay. I am going to close this PR and revisit it at a later time if needed.

awslabs / awsprocesscreds

Make mfa work with Okta and Google Authenticator app #21

Codecov Report