search

awslabs / awsprocesscreds

Process credential providers for AWS SDKs and Tools
Apache License 2.0
132 stars 40 forks source link

add F5 provider support #24

Closed Freedmont closed 6 years ago

Freedmont commented 6 years ago

Fixes #22

Our F5 SAML implementation is a generic SAML implementation, but the form does not have an "action"

This makes the form action optional and implements an F5 provider in case there are future differences between F5 and ADFS.

This is the first time I have made a PR on GitHub as well as the first time I have used many of the python tools required to contribute to this project, so I apologize if I have have done anything wrong. Any feedback would be much appreciated.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

codecov-io commented 6 years ago

Codecov Report

Merging #24 into master will increase coverage by 0.03%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #24      +/-   ##
==========================================
+ Coverage   98.09%   98.13%   +0.03%     
==========================================
  Files           5        5              
  Lines         315      321       +6     
  Branches       42       43       +1     
==========================================
+ Hits          309      315       +6     
  Misses          3        3              
  Partials        3        3
Impacted Files Coverage Δ
awsprocesscreds/cli.py 96.15% <ø> (ø) :arrow_up:
awsprocesscreds/saml.py 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update af46070...1fb444d. Read the comment docs.

JordonPhillips commented 6 years ago

Thanks for the PR! Unfortunately as I mentioned in #22 I don't think we'll be able to take this right now. The code itself looks great, and the unit test coverage is awesome! I would definitely keep your fork around though. If we get enough +1s on supporting F5 then we can pull in support. In the meantime, the license of this project is very lenient, so feel free to use and modify your fork as you like.