search

awslabs / benchmark-ai

Anubis (formerly known as Benchmark AI), measures the goodness of machine learning workloads
Apache License 2.0
16 stars 6 forks source link

Fix Flake8 update and pin version #1029

Closed Chancebair closed 4 years ago

Chancebair commented 4 years ago

Issue #, if available: https://github.com/awslabs/benchmark-ai/issues/1026

Description of changes: Flake8 updated and found some stuff, I pinned the version and fixed the lint failures

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Chancebair commented 4 years ago

Copying over @gavinmbell comment

Hi... What errors are we going to be suppressing?

--ignore=E902 seems to suppress IO/Errors (https://pep8.readthedocs.io/en/latest/intro.html)

--cosmetic-- I see removing all these "f" format print statements as clean up - since there is no formatting for them to work on. I would advocate for this being two diff PRs.

E902 is something I don't have time for, I opened https://github.com/awslabs/benchmark-ai/issues/1027

Those changes aren't cosmetic they are the lint failures Eduard is experiencing since Flake8 upgraded and started failing on these

Chancebair commented 4 years ago

Copying over @perdasilva comment

Maybe just add a comment to say that E902 is file not found - and it was added because not all packages have integration test folders - and maybe remove the ignore from src and test - since we expect that all packages have src and test?

I opened a ticket for this https://github.com/awslabs/benchmark-ai/issues/1027 and moved the ignore to the flake8 config file.

I also wonder whether we can remove the flake8 dependency here and in job-status-trigger since it it's part of the lint environment?

I don't think there is a lint environment, the python common makefile is utilized within each services subdirectory