awslabs / benchmark-ai

Anubis (formerly known as Benchmark AI), measures the goodness of machine learning workloads

Apache License 2.0

17 stars 6 forks source link

[feature] Add command line option to explicitly whitelist CIDR blocks #1031

Closed ryansteakley closed 4 years ago

ryansteakley commented 4 years ago

Issue #, if available:

1013

Description of changes: Added white listing of cider blocks. Had to include hotfix-ksonnet in order for code to successfully deploy By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

ryansteakley commented 4 years ago

I was able to run a benchmark and connect to the service endpoint from my local machine while not being aws configured and with the amazon vpn off. Is this an issue?

arjkesh commented 4 years ago

@ryansteakley can you ack that you've successfully deployed the most recent changes before merging?

arjkesh commented 4 years ago

@gavinmbell -- it says "This branch has not been deployed" on the PR -- is there a CI mechanism for deploying the changes? In other words, how can we get this message to say "this branch has been deployed"?