awslabs / benchmark-ai

Anubis (formerly known as Benchmark AI), measures the goodness of machine learning workloads
Apache License 2.0
18 stars 6 forks source link

Parmeterize DOCKER_REGISTRY in all publish & deployment processes #694

Open gavinmbell opened 5 years ago

gavinmbell commented 5 years ago

The key to portability of the system is the ability for users to determine where Docker containers are posted. Be it a personal repo account or on a team or the "official" repo, this should be able to be specified when executing the build/publish/deploy pipeline.

Chancebair commented 5 years ago

So from my conversations with Stas it appears that the DOCKER_REGISTRY variable is set in the pipeline stages local environment variables to point towards the ECR repos created by terraform. However there is one final step to add a pipeline step to build and publish the benchmarkai/ci:kind dockerfile to ECR and reference that in the codebuild project image stanza rather than the dockerhub image currently referenced