search

awslabs / clickstream-analytics-on-aws

Build clickstream analytics on AWS for your mobile and web applications
https://aws.amazon.com/solutions/implementations/clickstream-analytics-on-aws/
Apache License 2.0
70 stars 21 forks source link

No error when select 3 subnets in 2 AZs for data modeling #463

Open amliuyong opened 11 months ago

amliuyong commented 11 months ago

Summary

test case:

Expect: if user select the Redshift and as Serverless, the subnets user selected not cross in different 3 AZs, there will be error.

Actual: no error when I select 3 subnets in only 2 AZs (2 subnets in ap-northeast-1a, 1 subnet in ap-northeast-1c)

image

Steps to reproduce

What is the current bug behavior?

What is the expected correct behavior?

Relevant logs and/or screenshots

Possible fixes

This is :bug: Bug Report

zxkane commented 11 months ago

Did you see the validation error from server side when creating the pipeline on the review page?

chenhaiyun commented 11 months ago

I think this is not a bug. because some region only have 2 AZs, the validation logic is: 3 subnets cross 2 AZs

zxkane commented 11 months ago

Backend is checking the AZ count in the region, it only allows two AZs selected in the region only having two AZs.

https://github.com/awslabs/clickstream-analytics-on-aws/blob/e67012b7964517b060a9ca169ffbabd362798cfb/src/control-plane/backend/lambda/api/common/stack-params-valid.ts#L379