awslabs / clickstream-web

Web SDK for Clickstream Analytics on AWS
https://aws.amazon.com/solutions/implementations/clickstream-analytics-on-aws/
Apache License 2.0
15 stars 0 forks source link

fix: click event does not respond when disable the event bubbling #11

Closed zhu-xiaowei closed 1 year ago

zhu-xiaowei commented 1 year ago

Description

  1. fix click on the A label event does not respond when the event is prevented from bubbling

General Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: +13.10% :tada:

Comparison is base (dd678cc) 86.55% compared to head (f31a05b) 99.65%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #11 +/- ## =========================================== + Coverage 86.55% 99.65% +13.10% =========================================== Files 24 24 Lines 818 882 +64 Branches 112 151 +39 =========================================== + Hits 708 879 +171 Misses 3 3 + Partials 107 0 -107 ``` | [Files Changed](https://app.codecov.io/gh/awslabs/clickstream-web/pull/11?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs) | Coverage Δ | | |---|---|---| | [src/tracker/ClickTracker.ts](https://app.codecov.io/gh/awslabs/clickstream-web/pull/11?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs#diff-c3JjL3RyYWNrZXIvQ2xpY2tUcmFja2VyLnRz) | `100.00% <100.00%> (+21.62%)` | :arrow_up: | ... and [16 files with indirect coverage changes](https://app.codecov.io/gh/awslabs/clickstream-web/pull/11/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.