search

awslabs / cloudfront-hosting-toolkit

CloudFront Hosting Toolkit offers the convenience of a managed frontend hosting service while retaining full control over the hosting and deployment infrastructure to make it your own.
Apache License 2.0
95 stars 4 forks source link

You didn't fix #3 #6

Closed sholtomaud closed 4 months ago

sholtomaud commented 4 months ago

Expected Behaviour

fixed

Current Behaviour

not fixed

Code snippet

fix it

Possible Solution

fix it

Steps to Reproduce

fix #3

try npm i

cornelcroi commented 4 months ago

Can you please be more specific ? Have you installed the latest version 1.1.9 ? Can you give an example of what exactly is wrong? Or the stack trace with the error? It would help me to better understand the problem. Thanks.

sholtomaud commented 4 months ago

image

sholtomaud commented 4 months ago

image

sholtomaud commented 4 months ago

Also this is always galling and a bad look for billionaires

55 packages are looking for funding runnpm fundfor details

sholtomaud commented 4 months ago

Support those that support you

cornelcroi commented 4 months ago

Can you have another look at the readme page ? The "Getting Started with CDK" section has been updated and the sample code provided should work fine. Here is the sample code provided:

  import { RepositoryConnection, Hosting } from '@aws/cloudfront-hosting-toolkit';

  ...

  const config = {
      repoUrl: "https://github.com/USERNAME/REPOSITORY.git",
      branchName: "main",
      framework: "frameworkname"
  };
  const repositoryConnection = new RepositoryConnection(this, "MyRepositoryConnection", config)

  new Hosting(this, "MyHosting", {
      hostingConfiguration: config,
      buildFilePath: "buildConfigurationFile.yml",
      connectionArn: repositoryConnection.connectionArn,
      cffSourceFilePath: "index.js"
  });
sholtomaud commented 4 months ago

fixed