awslabs / coldsnap

A command line interface for Amazon EBS snapshots
Apache License 2.0
194 stars 24 forks source link

upload: support files over 2^31 bytes #171

Closed grahamc closed 2 years ago

grahamc commented 2 years ago

Description of changes:

Multiplying offset and blocks as i32 broke on larger images.

Co-authored-by: Cole Helbling cole.helbling@determinate.systems

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.


It would be really better if the interface didn't take signed integers at all, I assume this is Java internals leaking out through the generator.

grahamc commented 2 years ago

(rebased)

cbgbt commented 2 years ago

This looks great, thanks very much!

grahamc commented 2 years ago

Thanks!