search

awslabs / collectd-cloudwatch

A collectd plugin for sending data to Amazon CloudWatch
MIT License
200 stars 132 forks source link

added option to use proxy server Fixing Issue #20 #34

Closed bsangwan closed 7 years ago

bsangwan commented 7 years ago

Fixing issue #20 I added option to use proxy server if needed. I added new parameter "proxy_server_name" in plugin.conf file. At info log level the proxy server info will be logged at every metric push. I also updated the Readme and setup script to collect proxy server.

bsangwan commented 7 years ago

@sebasrp, We have to add proxy support as well as a silent configurator to meet our needs. Let me know of you are okay with this PR, I will create a new PR for adding silent configurator if you are okay with it.

bsangwan commented 7 years ago

@yimuniao I checked in all of your suggestions.

yimuniao commented 7 years ago

I realizes there is no unit test, could you add some unit tests to cover the new codes? And are your codes under MIT license?

bsangwan commented 7 years ago

Yes, its MIT license. I can add the testcase, but it will take time.

yimuniao commented 7 years ago

Thanks. Your contributions are very helpful.

yimuniao commented 7 years ago

Any update?

bsangwan commented 7 years ago

sorry for delay, I will work on it next week.

bsangwan commented 7 years ago

@yimuniao, I added testcase for new properties. Let me know if I miss something.

yimuniao commented 7 years ago

Fantastic. Thanks a lot.