search

awslabs / collectd-cloudwatch

A collectd plugin for sending data to Amazon CloudWatch
MIT License
200 stars 132 forks source link

Configurable Dimension support #43

Open linshu opened 7 years ago

linshu commented 7 years ago

Is there any plan to support configurable dimension, which we can configure different dimensions through a conf file or something similar?

mindstorms6 commented 7 years ago

Does #37 do what you're looking for?

linshu commented 7 years ago

I want a fully configuration dimension schema, not something hardcoded like "FixedDimension". Also, I can really add as many as possible (only limited by AWS cloudwatch) dimensions. I put the review on the lines I want to change in #37 Thanks.

Poil commented 7 years ago

You can try my old 2015 dev that was allowing that https://github.com/Poil/collectd_to_cloudwatch

Fodoj commented 7 years ago

@linshu I see you implemented the feature. Do you plan to make a PR to this repo?

linshu commented 7 years ago

@Fodoj Yes, I plan to do that. I am just doing more tests and see if anything I missed. If you think it is good, I can do the PR immediately. Thanks.

linshu commented 7 years ago

@Fodoj I opened a PR for this issue. Please take a look at it. Thanks.

linshu commented 6 years ago

What's update for this issue? Anything else are we waiting for from my side?