Ensure controller refs are used in VPC compositions - Githubissues

awslabs / crossplane-on-eks

Crossplane bespoke composition blueprints for AWS resources

Apache License 2.0

308 stars 109 forks source link

Ensure controller refs are used in VPC compositions #119

Closed nabuskey closed 1 year ago

nabuskey commented 1 year ago

What does this PR do?

Ensures controller refs are used in VPC compositions. This allows for multiple deployment of VPCs

More

[x] Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
[ ] Yes, I have added a new example under examples to support my PR
[ ] Yes, I have updated the docs for this feature
[ ] Yes, I have linked to an issue or feature request (applicable to PRs that solves a bug or a feature request)

Note:

Not all the PRs require examples and docs
We prefer small, well tested pull requests. Please ensure your pull requests are self-contained, and commits are squashed

For Moderators

[ ] E2E Test successfully complete before merge?

Additional Notes

candonov commented 1 year ago

@nabuskey Have you tested this? If so, can you ✅ the first option in the PR?

nabuskey commented 1 year ago

Yes this was tested :)