awslabs / crossplane-on-eks

Crossplane bespoke composition blueprints for AWS resources
Apache License 2.0
307 stars 109 forks source link

[FEATURE] Convert Compositions to Crossplane Functions #159

Open blakeromano opened 6 months ago

blakeromano commented 6 months ago

Is your feature request related to a problem? Please describe

With 1.14 Release of Crossplane Release and the opensource P&T function we should look to convert the Crossplane on EKS Compositions to use the function. There is a conversion CLI here https://github.com/crossplane-contrib/crossplane-migrator that can be used to help automate this process.

Describe the solution you'd like

I'd like to see the conversion to P&T function be done and see compositions usable with composition function pipelines.

nabuskey commented 6 months ago

Agreed. Since the feature is in beta now, we should definitely consider doing this. @candonov ^^.

candonov commented 6 months ago

Absolutely 💯! @blakeromano, are you interested in contributing?

blakeromano commented 6 months ago

I am not sure I have the time to do all the compositions. I did a quick example here https://github.com/blakeromano/crossplane-on-eks/tree/feature/start-pt-function-move if I could get help with testing it that'd be super appreciated.

huytn1219 commented 6 months ago

I can help contributing to this issue. @candonov

nabuskey commented 6 months ago

Since we have many compositions, we should start with a simple ones like the SQS and S3 ones.

candonov commented 6 months ago

Thank you @huytn1219. This s3 composition would be a good one to start with.