Closed vtumuluri closed 1 month ago
@candonov @johnphilips3 Is there anything blocking the review? The existing example under /examples/upbound-aws-provider/composite-resources/s3.yaml
already covers the use case which is the reason I haven't added another example. Also there are no additional elements introduced in this PR which is the reason I haven't modified any docs.
What does this PR do?
This PR fixes the
BucketPublicAccessBlock
resource by moving the access configuration fromspec
tospec.forProvider
as is expected from the CRD.Motivation
We use the S3 composition in our workflow and felt that it is beneficial to the community to contribute this fix rather than applying a local patch.
More
[x] Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
[ ] Yes, I have added a new example under examples to support my PR
[ ] Yes, I have updated the docs for this feature
[ ] Yes, I have linked to an issue or feature request (applicable to PRs that solves a bug or a feature request)
Note:
For Moderators
Additional Notes