awslabs / crossplane-on-eks

Crossplane bespoke composition blueprints for AWS resources
Apache License 2.0
307 stars 109 forks source link

Fix S3 BucketPublicAccessBlock configuration under spec.forProvider #186

Closed vtumuluri closed 1 month ago

vtumuluri commented 1 month ago

What does this PR do?

This PR fixes the BucketPublicAccessBlock resource by moving the access configuration from spec to spec.forProvider as is expected from the CRD.

Motivation

We use the S3 composition in our workflow and felt that it is beneficial to the community to contribute this fix rather than applying a local patch.

More

Note:

For Moderators

Additional Notes

vtumuluri commented 1 month ago

@candonov @johnphilips3 Is there anything blocking the review? The existing example under /examples/upbound-aws-provider/composite-resources/s3.yaml already covers the use case which is the reason I haven't added another example. Also there are no additional elements introduced in this PR which is the reason I haven't modified any docs.