awslabs / crossplane-on-eks

Crossplane bespoke composition blueprints for AWS resources
Apache License 2.0
307 stars 109 forks source link

Setting ArgoCD Health Status for Crossplane/Upbound Specific Kinds #198

Closed hflobao closed 3 weeks ago

hflobao commented 3 weeks ago

What does this PR do?

Change the Lua code in the resource.customizations to address situations where Composite Resources stay in the Provisioning status forever, mainly for the ProviderConfig Kind. It add tests for specific Kinds that does not have status or have just a status.users field. It also adds tests for the helm provider CRDs. Based on the guide on https://docs.crossplane.io/latest/guides/crossplane-with-argo-cd/

Motivation

To have a Composition deployed with ArgoCD and all resources with a green health status. In the case of the Composition I was building, the ProviderConfig for kubernetes and for helm needed this fix to became green.

More

Note:

For Moderators

Additional Notes

edgarsilva948 commented 3 weeks ago

thanks for the PR @hflobao! Great stuff. Keep it coming! :)

edgarsilva948 commented 3 weeks ago

@candonov LGTM!