docs: fix sed syntax in eksctl bootstrap guide

zxkane commented 2 years ago

What does this PR do?

Motivation

More

[x] Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
[ ] Yes, I have added a new example under examples to support my PR
[ ] Yes, I have updated the docs for this feature
[ ] Yes, I have linked to an issue or feature request (applicable to PRs that solves a bug or a feature request)

Note:

Not all the PRs require examples and docs
We prefer small, well tested pull requests. Please ensure your pull requests are self-contained, and commits are squashed

For Moderators

[ ] E2E Test successfully complete before merge?

Additional Notes

zxkane commented 2 years ago

yes, I ran the script on Ubuntu 18.04 + zsh.

$ uname -a
Linux ip-172-31-7-27 5.4.0-1075-aws #80~18.04.1-Ubuntu SMP Mon May 23 20:32:04 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

zxkane commented 2 years ago

update the sed usage for both GNU sed and BSD sed, it would create a bak file with suffix bak

nabuskey commented 2 years ago

So this is an issue with sed implementation differences. I assumed these commands are to be run on MacOS, thus BSD sed specific syntax. I tested these changes and the command changes here work with BSD and GNU sed. It will create a backup file which I wanted to avoid but insignificant in grand scheme of things.

@zxkane Thank you for these changes, did you ran into any other issues related to differences between BSD and GNU?

awslabs / crossplane-on-eks