feat: Updates across bootstrap and compositions

csantanapr commented 1 year ago

What does this PR do?

Updates the terraform example to be consistent with terraform-aws-eks-blueprints crossplane module.

Motivation

While reviewing the examples noticed some inconsistencies.

Make the main.tf example simpler and just do the minimum to show crossplane
Remove references to terrajet provider (deprecated)
Fix example not failing because of not finding provider config for aws and kubernetes

More

[x] Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
[ ] Yes, I have added a new example under examples to support my PR
[x] Yes, I have updated the docs for this feature
[ ] Yes, I have linked to an issue or feature request (applicable to PRs that solves a bug or a feature request)

Note:

Not all the PRs require examples and docs
We prefer small, well tested pull requests. Please ensure your pull requests are self-contained, and commits are squashed

For Moderators

[ ] E2E Test successfully complete before merge?

Additional Notes

csantanapr commented 1 year ago

This PR depends on terraform PR https://github.com/aws-ia/terraform-aws-eks-blueprints/pull/1220

nabuskey commented 1 year ago

This PR touches too many different areas. Please break it up into smaller PRs.

csantanapr commented 1 year ago

@nabuskey I can try but some parts are inter dependent, merging a small PR can cause some of the example not to be in working state

nimakaviani commented 1 year ago

+1 on @nabuskey 's suggestion.

if we keep each PR self-contained it will be easier to track changes and potentially revert if and where needed. @csantanapr if you can split this into some logically sound and separate PRs, that'd be great!

csantanapr commented 1 year ago

I will start working on braking the PR in parts

csantanapr commented 1 year ago

awslabs / crossplane-on-eks