awslabs / crossplane-on-eks

Crossplane bespoke composition blueprints for AWS resources
Apache License 2.0
322 stars 111 forks source link

Follow naming conventions for Composite and Claims XIAMPolicy #75

Closed csantanapr closed 1 year ago

csantanapr commented 1 year ago

What does this PR do?

Follow naming conventions for Composite and Claims XIAMPolicy

Motivation

Found out that this is the only composite from the package not following the convention for naming Composite Resources (XR)

More

Note:

For Moderators

Additional Notes

nabuskey commented 1 year ago

IAM policy compositions are not meant to be claimed, they are meant to be part of another composition. Thus it doesn't follow the naming convention.

nimakaviani commented 1 year ago

I dont think it hurts for them to follow the naming convention tho. any particular concerns around having them named similarly?

nabuskey commented 1 year ago

Yeah that's fine, but the XRD needs not updated for supporting claims.

csantanapr commented 1 year ago

@nimakaviani @nabuskey PTAL when you have a chance I addressed the review feedback Removed the claim capability