Closed candonov closed 1 year ago
Want to delete the values.yaml file not being used?
Trying it now and reading the README.md
It has:
export AWS_REGION=<ENTER YOUR REGION>
terraform plan
I think it should be:
export TF_VAR_region=<ENTER YOUR REGION>
terraform plan
Terraform aws provider is OK with AWS_REGION
environment variable: https://registry.terraform.io/providers/hashicorp/aws/latest/docs#environment-variables
Terraform aws provider is OK with AWS_REGION environment variable: https://registry.terraform.io/providers/hashicorp/aws/latest/docs#environment-variables
I understand but the order is "Parameters in the provider configuration" then "Environment variables"
Configuration for the AWS Provider can be derived from several sources, which are applied in the following order:
- Parameters in the provider configuration
- Environment variables
- Shared credentials files
- Shared configuration files
- Container credentials
- Instance profile credentials and region
And we configure Parameters in the provider configuration with a default value of us-east-1
here:
https://github.com/awslabs/crossplane-on-eks/blob/main/bootstrap/terraform/main.tf#L4-L6
I think this is something we can fix in another PR if you want
Terraform aws provider is OK with AWS_REGION environment variable: https://registry.terraform.io/providers/hashicorp/aws/latest/docs#environment-variables
I understand but the order is "Parameters in the provider configuration" then "Environment variables"
Configuration for the AWS Provider can be derived from several sources, which are applied in the following order:
- Parameters in the provider configuration
- Environment variables
- Shared credentials files
- Shared configuration files
- Container credentials
- Instance profile credentials and region
And we configure Parameters in the provider configuration with a default value of
us-east-1
here: https://github.com/awslabs/crossplane-on-eks/blob/main/bootstrap/terraform/main.tf#L4-L6I think this is something we can fix in another PR if you want
Oh, thank you! I didn't realize the var will take precedence. I will fix it here.
What does this PR do?
Adds installation for
helm-provider
andupbound-aws-provider
.Motivation
Resolves: https://github.com/awslabs/crossplane-on-eks/issues/9
More
[X] Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
[x] Yes, I have added a new example under examples to support my PR
[X] Yes, I have updated the docs for this feature
[X] Yes, I have linked to an issue or feature request (applicable to PRs that solves a bug or a feature request)
For Moderators
Additional Notes
Tested upbound aws-provider by successfully creating an S3 bucket:
Tested helm provider by successfully creating a helm release: