awslabs / damo

DAMON user-space tool
https://damonitor.github.io/
GNU General Public License v2.0
151 stars 27 forks source link

Integrate commands for making outputs #105

Closed sj-aws closed 5 days ago

sj-aws commented 1 month ago

There are multiple commands for making some outputs: show, status, record, and fmt_json. Let's integrate those into one command (probably show) for simplicity.

sj-aws commented 1 month ago

This will also helps supporting yaml-format DAMON parameters formatting[1]. For example,

# damo show damon_params --format json
# damo show damon_params --format yaml

[1] https://github.com/awslabs/damo/pull/97#issuecomment-2150451395

sjp38 commented 1 month ago

Actually, nearly every damo commands except DAMON controlling (start/stop/tune) are somewhat for making some output. Maybe further categorizing is better...

sjp38 commented 1 month ago

Now, the plan is to replace old workflow for collecting data and visualizing. For this, we will introduce three new commands.

sjp38 commented 1 month ago

args command is added with support of json and yaml format DAMON parameters generation. The commit for yaml format support is d481e66

sj-aws commented 5 days ago

After 2024-09-05, we will[1] use damonitor repo[2] as the only main repo for GitHub. To continue discussion of this issue on the repo, I just created a new issue[3] there. Please use the new issue for followup discussions.

Closing this issue in favor of the new one on the damonitor repo. Please ask me to open this again if you cannot continue the discussion from the new issue.

[1] https://lore.kernel.org/20240813232158.83903-1-sj@kernel.org [2] https://github.com/damonitor/damo [3] https://github.com/damonitor/damo/issues/11