search

awslabs / damo

DAMON user-space tool
https://damonitor.github.io/
GNU General Public License v2.0
155 stars 26 forks source link

_damon_result: Do not return error in start_monitoring_record #40

Closed honggyukim closed 1 year ago

honggyukim commented 1 year ago

The following commit removed returning error message in _damon_result.start_monitoring_record.

fcac3e0 _damon_result: Enhance set_perf_path with perf record test

So there's no need to return error code here and it can be removed.

sj-aws commented 1 year ago

Looks great to me, thank you for fixing this, Honggyu!

honggyukim commented 1 year ago

Hi SeongJae, thanks for building this great tool!

sj-aws commented 1 year ago

You're welcome. And thank you for building this tool together :)

honggyukim commented 1 year ago

Hi SeongJae,

It's been a while for this chat thread, but I saw that there is an online meeting at April 3, 18:00 in PDT, which is April 4, 10:00 in KST. If so, can I join the meeting through google meet link? https://lore.kernel.org/damon/20220810225102.124459-1-sj@kernel.org/

sj-aws commented 1 year ago

Hi Honghyu,

Sure, we still having the chat series, and the link is still working. Please feel free to join! Looking forward to talk with you!

Thanks, SJ

honggyukim commented 1 year ago

Thanks. See you soon :)