search

awslabs / damo

DAMON user-space tool
https://damonitor.github.io/
GNU General Public License v2.0
155 stars 26 forks source link

Refactor damo_version.py #42

Closed michel-slm closed 1 year ago

michel-slm commented 1 year ago

damo_version.py is currently a text file; this makes it difficult to package in distributions which expect *.py files to be valid Python that can be byte-compiled.

Convert it to a valid file, and adjust damo and setup.py to source it appropriately. This also means we can stop patching the version in with sed in packaging/build.sh.

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

sj-aws commented 1 year ago

All looks great. Thank you for this PR, Michel!

michel-slm commented 1 year ago

Thanks @sj-aws ! Saw your talk at OSSNA and definitely interested in using this, I'm getting it packaged in Fedora

sj-aws commented 1 year ago

I couldn't be more glad than hearing that, thank you Michel! Please let me know if you get any trouble while doing the packaging!