awslabs / damo

DAMON user-space tool
https://damonitor.github.io/
GNU General Public License v2.0
148 stars 28 forks source link

"failed to turn damon off" after running damo schemes #53

Closed honggyukim closed 1 year ago

honggyukim commented 1 year ago

Hi SeongJae,

It might be a trivial issue but I see an error at the end of execution for damo schemes as follows.

$ sudo ./damo schemes --damos_access_rate 0 0 --damos_sz_region 4K max --damos_age 1s max --damos_action pageout "./masim/masim ./masim/configs/stairs.cfg"
Press Ctrl+C to stop
initial phase:                88,565 accesses/msec, 10000 msecs run
phase 0:                      97,596 accesses/msec, 5000 msecs run
phase 1:                      97,412 accesses/msec, 5000 msecs run
phase 2:                      97,884 accesses/msec, 5000 msecs run
phase 3:                      97,760 accesses/msec, 5001 msecs run
phase 4:                      98,100 accesses/msec, 5001 msecs run
phase 5:                      97,229 accesses/msec, 5000 msecs run
phase 6:                      97,229 accesses/msec, 5000 msecs run
phase 7:                      86,166 accesses/msec, 5000 msecs run
phase 8:                      93,952 accesses/msec, 5000 msecs run
phase 9:                      95,866 accesses/msec, 5000 msecs run
failed to turn damon off (writing off to /sys/kernel/mm/damon/admin/kdamonds/0/state failed ([Errno 1] Operation not permitted))

It doesn't actually a problem for me now but might be better to suppress this error message.

sj-aws commented 1 year ago

Thank you for reporting this, I will take a look soon!

sj-aws commented 1 year ago

Fixed with https://github.com/awslabs/damo/commit/2ab78d0d343c8400a608036a0d8caf2bbff8fa67. It will also be included in next release, which is scheduled for 2023-06-19 PT. Please open this again if the fix doesn't work for you.

honggyukim commented 1 year ago

Thanks a lot for the fix. I tested it and see that the error message is disappeared now.