Closed honggyukim closed 3 weeks ago
Thank you for this kind report, Honggyu! I wanted to learn more about the pre-commit hook and use it, but unfortunately couldn't find time for that so far. Let me try more. I will fix the reported issues first.
I successfully installed pre-commit
on my development machine and fixed all warnings.
Thanks. Maybe we can think about adding some description about pre-commit
at CONTRIBUTING file just like https://github.com/namhyung/uftrace/blob/master/CONTRIBUTING.md#coding-style.
Hi SeongJae,
I've added pre-commit hooks before at #62, but it seems that you didn't install its hooks.
So the current pre-commit hooks complain a lot as follows.
It'd be better to run
pre-commit install
before making commits from now on unless you don't like these kind warnings.