feat: tags + security group and karpenter helm config updates - Githubissues

awslabs / data-on-eks

DoEKS is a tool to build, deploy and scale Data & ML Platforms on Amazon EKS

https://awslabs.github.io/data-on-eks/

Apache License 2.0

550 stars 180 forks source link

feat: tags + security group and karpenter helm config updates #548

Closed sanjeevrg89 closed 3 weeks ago

sanjeevrg89 commented 3 weeks ago

What does this PR do?

In MNGs we were adding karpenter tags which was not necessary
Security group IDs were missing in karpenter helm config
Removed karpenter tags for 100.x subnets
Default Nodepool and Inferentia-inf2 nodepools were not getting created before the above fixes resolved the issue.

🛑 Please open an issue first to discuss any significant work and flesh out details/direction - we would hate for your time to be wasted. Consult the CONTRIBUTING guide for submitting pull-requests.

Motivation

More

[Yes ] Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
[ Yes] Mandatory for new blueprints. Yes, I have added a example to support my blueprint PR
[Yes ] Mandatory for new blueprints. Yes, I have updated the website/docs or website/blog section for this feature
[ Yes] Yes, I ran pre-commit run -a with this PR. Link for installing pre-commit locally

For Moderators

[ ] E2E Test successfully complete before merge?

Additional Notes