awslabs / deequ

Deequ is a library built on top of Apache Spark for defining "unit tests for data", which measure data quality in large datasets.
Apache License 2.0
3.18k stars 519 forks source link

containsCreditCardNumber analyser constraint doesnt support for JCB credit card #533

Open kakampassi opened 4 months ago

kakampassi commented 4 months ago

Describe the bug containsCreditCardNumber analyser constraint doesnt support for JCB credit card

To Reproduce // Visa, MasterCard, AMEX, Diners Club val CREDITCARD: Regex = """\b(?:3[47]\d{2}([\ -]?)\d{6}\1\d|(?:(?:4\d|5[1-5]|65)\d{2}|6011)([\ -]?)\d{4}\2\d{4}\2)\d{4}\b""".r

The below two credit card doesnt belong to any of the above CC type. They belong to JCB credit card. 3566002020360505 , 3530111333300000

Expected behavior It should support JCB credit card as well

Reference https://github.com/awslabs/deequ/blob/master/src/main/scala/com/amazon/deequ/analyzers/PatternMatch.scala